-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13170] Enable use of new generators on web #11405
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11405 +/- ##
==========================================
+ Coverage 33.28% 33.29% +0.01%
==========================================
Files 2729 2730 +1
Lines 85559 85576 +17
Branches 16316 16319 +3
==========================================
+ Hits 28475 28490 +15
- Misses 54823 54825 +2
Partials 2261 2261 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Lookin' good! Just a nit.
<app-header></app-header> | ||
|
||
<bit-container> | ||
<!-- Will get replaced with <tools-credential-generator /> once https://github.com/bitwarden/clients/pull/11398 has been merged --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ I've been calling out things to address in later commits using FIXME: xyz
. That way it's easy to find tech debt with grep
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed with ff18d01
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13170
📔 Objective
Create a web-specific hosting component for the new credential-generator. Temporarily, this is going to use the new password-generator component, but will be replaced once #11398 has merged.
The swap is guarded by a feature flag, so this can be merged without affecting current production.
📸 Screenshots
Before
After (temporary)
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes